[#544] Addressed review comments

Minor clean ups.

diff --git a/doc/sphinx/arm/hooks-lease-cmds.rst b/doc/sphinx/arm/hooks-lease-cmds.rst
index 85223cbd6df4d86824eccf6f7a93bd8ec7659b5a..f8a1d91d3fec0f28208bfb02894c4b310861aef8 100644 (file)
--- a/doc/sphinx/arm/hooks-lease-cmds.rst
+++ b/doc/sphinx/arm/hooks-lease-cmds.rst
@@ -723,8 +723,8 @@ leases were found.
 
 .. _command-lease6-get-by-hostname:
 
-The lease4-get-by-*, lease6-get-by-* Commands
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The lease4-get-by-\*, lease6-get-by-\* Commands
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
 ``leaseX-get-by-Y`` can be used to query the lease database and
 retrieve all existing leases with a specified hardware address (IPv4
@@ -802,7 +802,7 @@ An example IPv4 lease deletion by "hw-address" is:
    }
 
 
-As of Kea 1.7.10, a new parameter, "update-ddns", is supported (IPv4 and IPv6).
+As of Kea 1.7.10, a new parameter, ``update-ddns``, is supported (IPv4 and IPv6).
 When true it instructs the server to queue a request to kea-dhcp-ddns to
 remove DNS entries after the lease is successfully deleted if:
 

diff --git a/src/hooks/dhcp/lease_cmds/lease_cmds.h b/src/hooks/dhcp/lease_cmds/lease_cmds.h
index 63f29606e370230461adbeceaaa31201ce157efb..31dd8b6cd19f494636bb23cfe04473e7cbda129c 100644 (file)
--- a/src/hooks/dhcp/lease_cmds/lease_cmds.h
+++ b/src/hooks/dhcp/lease_cmds/lease_cmds.h
@@ -92,6 +92,9 @@ public:
     /// where multiple IPv6 addresses and/or prefixes can be allocated for
     /// a single DHCPv6 packet.
     ///
+    /// @note Unlike leaseX-del, this command does not support "update-ddns" and
+    /// this will not generate CHG_REMOVEs for deleted leases.
+    ///
     /// Example structure of the command:
     ///
     /// {

diff --git a/src/hooks/dhcp/lease_cmds/tests/lease_cmds_unittest.cc b/src/hooks/dhcp/lease_cmds/tests/lease_cmds_unittest.cc
index 93fc3bf3b9d84c1ff1bd25fa34230a85ac06b173..c5482a82caf141a5ba9f9602a1d26a14eefcc40e 100644 (file)
--- a/src/hooks/dhcp/lease_cmds/tests/lease_cmds_unittest.cc
+++ b/src/hooks/dhcp/lease_cmds/tests/lease_cmds_unittest.cc
@@ -5520,7 +5520,6 @@ TEST_F(LeaseCmdsTest, lease6DnsRemoveD2Enabled) {
             "{"
             "    \"command\": \"lease6-del\","
             "    \"arguments\": {"
-            "        \"subnet-id\": 66,\n"
             "        \"ip-address\": \"2001:db8:1::8\"\n";
 
         if (!scenario.update_ddns_.empty()) {
@@ -5561,7 +5560,6 @@ TEST_F(LeaseCmdsTest, lease6DnsRemoveD2Disabled) {
         "{\n"
         "    \"command\": \"lease6-del\",\n"
         "    \"arguments\": {\n"
-        "        \"subnet-id\": 66,\n"
         "        \"ip-address\": \"2001:db8:1::8\",\n"
         "        \"update-ddns\": true\n"
         "    }\n"