[#2844] addressed comments

diff --git a/src/lib/dhcp/option_custom.cc b/src/lib/dhcp/option_custom.cc
index 6e236a8f72d8aace8c14e73ce9df1b508129e58d..acfc587b71da65281ab0d4f11a29247ca4854c76 100644 (file)
--- a/src/lib/dhcp/option_custom.cc
+++ b/src/lib/dhcp/option_custom.cc
@@ -454,7 +454,7 @@ OptionCustom::dataFieldToText(const OptionDataType data_type,
         break;
     }
     default:
-        ;
+        break;
     }
 
     // Append data field type in brackets.

diff --git a/src/lib/dhcp/tests/pkt4_unittest.cc b/src/lib/dhcp/tests/pkt4_unittest.cc
index 212a7728968e79b24b46540c83084760b64fb7d6..45e2441dd6965e4c255228cfb57491ea0735cb14 100644 (file)
--- a/src/lib/dhcp/tests/pkt4_unittest.cc
+++ b/src/lib/dhcp/tests/pkt4_unittest.cc
@@ -1284,10 +1284,10 @@ TEST_F(Pkt4Test, toText) {
     pkt.addOption(OptionPtr(new Option4AddrLst(123, IOAddress("192.0.2.3"))));
     pkt.addOption(OptionPtr(new OptionUint32(Option::V4, 156, 123456)));
     pkt.addOption(OptionPtr(new OptionString(Option::V4, 87, "lorem ipsum")));
-    OptionBuffer data = { 'a', 'b', 'c', 'd', 'e', 'f' };
+    OptionBuffer data = { 0x61, 0x62, 0x63, 0x64, 0x65, 0x66 };
     OptionPtr opt(new Option(Option::V4, 231, data));
     pkt.addOption(opt);
-    OptionBuffer data_sub = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '0' };
+    OptionBuffer data_sub = { 0x30, 0x31, 0x32, 0x33, 0x34, 0x35, 0x36, 0x37, 0x38, 0x39 };
     OptionPtr sub_opt(new Option(Option::V4, 1, data_sub));
     opt->addOption(sub_opt);
     data_sub.clear();
@@ -1303,7 +1303,7 @@ TEST_F(Pkt4Test, toText) {
               "  type=156, len=004: 123456 (uint32)\n"
               "  type=231, len=021: 61:62:63:64:65:66 (abcdef),\n"
               "options:\n"
-              "    type=001, len=011: 30:31:32:33:34:35:36:37:38:39:30 (01234567890)\n"
+              "    type=001, len=011: 30:31:32:33:34:35:36:37:38:39 (0123456789)\n"
               "    type=002, len=000: (no data)",
               pkt.toText());