[5226] Addressed review comments

diff --git a/src/lib/dhcp/option_custom.h b/src/lib/dhcp/option_custom.h
index 6af94c37f1b6cb047247b1dddcf4b36a7a021463..1dcdc00264b1704ab53c73f3172685e275e3e4e2 100644 (file)
--- a/src/lib/dhcp/option_custom.h
+++ b/src/lib/dhcp/option_custom.h
@@ -427,6 +427,7 @@ private:
     /// @param end iterator to end of input data.
     ///
     /// @return size of data to copy to the buffer.
+    /// @throw isc::OutOfRange if option buffer is truncated.
     size_t bufferLength(const OptionDataType data_type, bool in_array,
                         OptionBuffer::const_iterator begin,
                         OptionBuffer::const_iterator end) const;

diff --git a/src/lib/dhcp/tests/option_custom_unittest.cc b/src/lib/dhcp/tests/option_custom_unittest.cc
index ba7bc3f2ea4acf882ddb6c28861fc40705e9998d..d92784fa67058f5a4275f4bc3e1c8fd12f20e783 100644 (file)
--- a/src/lib/dhcp/tests/option_custom_unittest.cc
+++ b/src/lib/dhcp/tests/option_custom_unittest.cc
@@ -1301,7 +1301,7 @@ TEST_F(OptionCustomTest, recordArrayData) {
     // Initialize field 0 to 8712.
     writeInt<uint16_t>(8712, buf);
     // Initialize field 1 to 'true'
-    buf.push_back(static_cast<unsigned short>(1));
+    writeInt<uint8_t>(1, buf);
     // Initialize field 2 to 'mydomain.example.com'.
     buf.insert(buf.end(), fqdn_data, fqdn_data + sizeof(fqdn_data));
     // Initialize field 3 to IPv4 address.