gpib: Fix error code in ibonline()

This accidentally returns 1 on error, but it should return negative
error codes.

Fixes: 9dde4559e939 ("staging: gpib: Add GPIB common core driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aSlMnaT1M104NJb2@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/gpib/common/iblib.c b/drivers/gpib/common/iblib.c
index 7cbb6a467177da2205a782aedca6091f93ff97cc..b672dd6aad25f2f4f36d2a0ed78a0625651ac8ba 100644 (file)
--- a/drivers/gpib/common/iblib.c
+++ b/drivers/gpib/common/iblib.c
@@ -227,11 +227,10 @@ int ibonline(struct gpib_board *board)
 #ifndef CONFIG_NIOS2
        board->autospoll_task = kthread_run(&autospoll_thread, board,
                                            "gpib%d_autospoll_kthread", board->minor);
-       retval = IS_ERR(board->autospoll_task);
-       if (retval) {
+       if (IS_ERR(board->autospoll_task)) {
                dev_err(board->gpib_dev, "failed to create autospoll thread\n");
                board->interface->detach(board);
-               return retval;
+               return PTR_ERR(board->autospoll_task);
        }
 #endif
        board->online = 1;