]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
vfs_gpfs: Remove function call from "if" statement
authorChristof Schmitt <cs@samba.org>
Thu, 16 Jan 2020 19:15:29 +0000 (12:15 -0700)
committerJeremy Allison <jra@samba.org>
Tue, 21 Jan 2020 22:08:41 +0000 (22:08 +0000)
Follow the current coding guidelines to first issue the function call
and then check the return code.

Signed-off-by: Christof Schmitt <cs@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/modules/vfs_gpfs.c

index efc00e21f9185fe1b234e249970034cd7fa530df..240b6839d0bfc5b20e99e3ef425ad44826d4099f 100644 (file)
@@ -246,8 +246,8 @@ static int vfs_gpfs_setlease(vfs_handle_struct *handle,
                                struct gpfs_config_data,
                                return -1);
 
-       if (linux_set_lease_sighandler(fsp->fh->fd) == -1) {
-               ret = -1;
+       ret = linux_set_lease_sighandler(fsp->fh->fd);
+       if (ret == -1) {
                goto failure;
        }