]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
trunk: We don't free we drain _then_ free.
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Tue, 24 Mar 2020 16:19:50 +0000 (10:19 -0600)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Wed, 25 Mar 2020 16:07:03 +0000 (10:07 -0600)
src/lib/server/trunk.c

index 5c175697172baa9d2638b84f0cac7ef45f57d898..610376edf353fa1fb742691bd173067e6a6f144e 100644 (file)
@@ -3521,8 +3521,8 @@ static void trunk_manage(fr_trunk_t *trunk, fr_time_t now, char const *caller)
                /*
                 *      Inactive connections get counted in the
                 *      set of viable connections, but are likely
-                *      to be congested or dead, so we free those
-                *      first.
+                *      to be congested or dead, so we drain
+                *      (and possibly eventually free) those first.
                 */
                if ((tconn = fr_dlist_tail(&trunk->inactive))) {
                        trunk_connection_enter_inactive_draining(tconn);
@@ -3539,7 +3539,7 @@ static void trunk_manage(fr_trunk_t *trunk, fr_time_t now, char const *caller)
                /*
                 *      Finally if there are no "connecting"
                 *      connections to close, and no "inactive"
-                *      connections, start freeing "active"
+                *      connections, start draining "active"
                 *      connections.
                 */
                } else if ((tconn = fr_heap_peek_tail(trunk->active))) {