]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: proximity: vcnl3020: pass struct vcnl3020_property by pointer
authorDavid Lechner <dlechner@baylibre.com>
Sat, 28 Jun 2025 18:23:48 +0000 (13:23 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 13 Jul 2025 14:36:23 +0000 (15:36 +0100)
Pass struct vcnl3020_property by pointer instead of by value to avoid
copying the entire struct.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250628-iio-const-data-25-v1-1-5d99cf17790e@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/proximity/vcnl3020.c

index 31e77d9e0c90e503e5e337f1ae7f17587624a785..234bdad543cc25e59ace336d2870356b9521f8c8 100644 (file)
@@ -109,22 +109,22 @@ static struct vcnl3020_property vcnl3020_led_current_property = {
 };
 
 static int vcnl3020_get_and_apply_property(struct vcnl3020_data *data,
-                                          struct vcnl3020_property prop)
+                                          struct vcnl3020_property *prop)
 {
        int rc;
        u32 val;
 
-       rc = device_property_read_u32(data->dev, prop.name, &val);
+       rc = device_property_read_u32(data->dev, prop->name, &val);
        if (rc)
                return 0;
 
-       if (prop.conversion_func)
-               prop.conversion_func(&val);
+       if (prop->conversion_func)
+               prop->conversion_func(&val);
 
-       rc = regmap_write(data->regmap, prop.reg, val);
+       rc = regmap_write(data->regmap, prop->reg, val);
        if (rc) {
                dev_err(data->dev, "Error (%d) setting property (%s)\n",
-                       rc, prop.name);
+                       rc, prop->name);
        }
 
        return rc;
@@ -153,7 +153,7 @@ static int vcnl3020_init(struct vcnl3020_data *data)
        mutex_init(&data->lock);
 
        return vcnl3020_get_and_apply_property(data,
-                                              vcnl3020_led_current_property);
+                                              &vcnl3020_led_current_property);
 };
 
 static bool vcnl3020_is_in_periodic_mode(struct vcnl3020_data *data)