]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_TYPED_PARAM_STRING
authorPeter Krempa <pkrempa@redhat.com>
Wed, 16 Feb 2022 15:20:23 +0000 (16:20 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 17 Feb 2022 12:15:46 +0000 (13:15 +0100)
This was a lockout to make strings in typed parameters compatible with
versions which didn't have them. Now all drivers need to expose this
capability.

This namely enables it for 'esx' and 'vz' drivers, while they don't seem
to be implementing any parameters for now, they might later.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/driver.c

index 9852a1cb17a335e145887181a34460f7193718ce..d070861cfdf788f0de118d3d9ccd6071f3d231e6 100644 (file)
@@ -353,7 +353,13 @@ virDriverFeatureIsGlobal(virDrvFeature feat,
         *supported = 0;
         return true;
 
+    /* Limitation of string support in typed parameters was an RPC limitation.
+     * At this point everything supports them and thus also drivers need to
+     * always advertise this feature */
     case VIR_DRV_FEATURE_TYPED_PARAM_STRING:
+        *supported = 1;
+        return true;
+
     case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER:
     case VIR_DRV_FEATURE_FD_PASSING:
     case VIR_DRV_FEATURE_MIGRATION_V2: