]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ALSA: hda - fix the micmute led status for Lenovo ThinkCentre AIO
authorHui Wang <hui.wang@canonical.com>
Mon, 10 Aug 2020 02:16:59 +0000 (10:16 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Aug 2020 06:24:12 +0000 (08:24 +0200)
commit 386a6539992b82fe9ac4f9dc3f548956fd894d8c upstream.

After installing the Ubuntu Linux, the micmute led status is not
correct. Users expect that the led is on if the capture is disabled,
but with the current kernel, the led is off with the capture disabled.

We tried the old linux kernel like linux-4.15, there is no this issue.
It looks like we introduced this issue when switching to the led_cdev.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20200810021659.7429-1-hui.wang@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/pci/hda/patch_realtek.c

index b27d88c860672cb104e56e696fa466d001d4bcc8..313eecfb91b44f1b28a80ff6ebc9387dc395db7e 100644 (file)
@@ -4391,6 +4391,7 @@ static void alc233_fixup_lenovo_line2_mic_hotkey(struct hda_codec *codec,
 {
        struct alc_spec *spec = codec->spec;
 
+       spec->micmute_led_polarity = 1;
        alc_fixup_hp_gpio_led(codec, action, 0, 0x04);
        if (action == HDA_FIXUP_ACT_PRE_PROBE) {
                spec->init_amp = ALC_INIT_DEFAULT;