btrfs: change dump_block_groups() in btrfs_dump_space_info() from int to bool

btrfs_dump_space_info()'s parameter dump_block_groups is used as a boolean
although it is defined as an integer.

Change it from int to bool.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: Daniel Vacek <neelx@suse.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
index 00e567a4cd1608b4b6d5dba4ea3954e767c87d37..fb62a8cf03b32aa483df1432f6a74316ccf0a443 100644 (file)
--- a/fs/btrfs/block-group.c
+++ b/fs/btrfs/block-group.c
@@ -1403,7 +1403,7 @@ out:
        if (ret == -ENOSPC && btrfs_test_opt(cache->fs_info, ENOSPC_DEBUG)) {
                btrfs_info(cache->fs_info,
                        "unable to make block group %llu ro", cache->start);
-               btrfs_dump_space_info(cache->fs_info, cache->space_info, 0, 0);
+               btrfs_dump_space_info(cache->fs_info, cache->space_info, 0, false);
        }
        return ret;
 }
@@ -4298,7 +4298,7 @@ static void reserve_chunk_space(struct btrfs_trans_handle *trans,
        if (left < bytes && btrfs_test_opt(fs_info, ENOSPC_DEBUG)) {
                btrfs_info(fs_info, "left=%llu, need=%llu, flags=%llu",
                           left, bytes, type);
-               btrfs_dump_space_info(fs_info, info, 0, 0);
+               btrfs_dump_space_info(fs_info, info, 0, false);
        }
 
        if (left < bytes) {
@@ -4443,7 +4443,7 @@ static void check_removing_space_info(struct btrfs_space_info *space_info)
         * indicates a real bug if this happens.
         */
        if (WARN_ON(space_info->bytes_pinned > 0 || space_info->bytes_may_use > 0))
-               btrfs_dump_space_info(info, space_info, 0, 0);
+               btrfs_dump_space_info(info, space_info, 0, false);
 
        /*
         * If there was a failure to cleanup a log tree, very likely due to an
@@ -4454,7 +4454,7 @@ static void check_removing_space_info(struct btrfs_space_info *space_info)
        if (!(space_info->flags & BTRFS_BLOCK_GROUP_METADATA) ||
            !BTRFS_FS_LOG_CLEANUP_ERROR(info)) {
                if (WARN_ON(space_info->bytes_reserved > 0))
-                       btrfs_dump_space_info(info, space_info, 0, 0);
+                       btrfs_dump_space_info(info, space_info, 0, false);
        }
 
        WARN_ON(space_info->reclaim_size > 0);

diff --git a/fs/btrfs/space-info.c b/fs/btrfs/space-info.c
index 517916004f212b8272aba631b64ef58e709a731e..0481c693ac2eafc2d9ca227b5cace959534558d2 100644 (file)
--- a/fs/btrfs/space-info.c
+++ b/fs/btrfs/space-info.c
@@ -615,7 +615,7 @@ static void __btrfs_dump_space_info(const struct btrfs_fs_info *fs_info,
 
 void btrfs_dump_space_info(struct btrfs_fs_info *fs_info,
                           struct btrfs_space_info *info, u64 bytes,
-                          int dump_block_groups)
+                          bool dump_block_groups)
 {
        struct btrfs_block_group *cache;
        u64 total_avail = 0;
@@ -1887,7 +1887,7 @@ int btrfs_reserve_metadata_bytes(struct btrfs_fs_info *fs_info,
                                              space_info->flags, orig_bytes, 1);
 
                if (btrfs_test_opt(fs_info, ENOSPC_DEBUG))
-                       btrfs_dump_space_info(fs_info, space_info, orig_bytes, 0);
+                       btrfs_dump_space_info(fs_info, space_info, orig_bytes, false);
        }
        return ret;
 }
@@ -1918,7 +1918,7 @@ int btrfs_reserve_data_bytes(struct btrfs_space_info *space_info, u64 bytes,
                trace_btrfs_space_reservation(fs_info, "space_info:enospc",
                                              space_info->flags, bytes, 1);
                if (btrfs_test_opt(fs_info, ENOSPC_DEBUG))
-                       btrfs_dump_space_info(fs_info, space_info, bytes, 0);
+                       btrfs_dump_space_info(fs_info, space_info, bytes, false);
        }
        return ret;
 }

diff --git a/fs/btrfs/space-info.h b/fs/btrfs/space-info.h
index 7de31541ab459a48f8ab94eacb647ded19ee6ed4..679f22efb4073fa59b1a632f541ac56b929daa4c 100644 (file)
--- a/fs/btrfs/space-info.h
+++ b/fs/btrfs/space-info.h
@@ -278,7 +278,7 @@ u64 __pure btrfs_space_info_used(const struct btrfs_space_info *s_info,
 void btrfs_clear_space_info_full(struct btrfs_fs_info *info);
 void btrfs_dump_space_info(struct btrfs_fs_info *fs_info,
                           struct btrfs_space_info *info, u64 bytes,
-                          int dump_block_groups);
+                          bool dump_block_groups);
 int btrfs_reserve_metadata_bytes(struct btrfs_fs_info *fs_info,
                                 struct btrfs_space_info *space_info,
                                 u64 orig_bytes,