]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuDomainUSBAddressAddHubs: Refactor cleanup
authorPeter Krempa <pkrempa@redhat.com>
Wed, 4 Aug 2021 09:08:49 +0000 (11:08 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Fri, 6 Aug 2021 06:53:26 +0000 (08:53 +0200)
'hub' doesn't need to be freed any more because it's always consumed and
NULLed-out by VIR_APPEND element. This also makes the 'ret' variable
obsolete.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_domain_address.c

index 40e84cce9c9a3ab216fe70deeacb73a1f648e0ab..392368bd38e4c467dc3b5fbd2fbeb17df85b08ff 100644 (file)
@@ -2942,7 +2942,6 @@ qemuDomainUSBAddressAddHubs(virDomainDef *def)
     virDomainHubDef *hub = NULL;
     size_t available_ports;
     size_t hubs_needed = 0;
-    int ret = -1;
     size_t i;
 
     available_ports = virDomainUSBAddressCountAllPorts(def);
@@ -2972,9 +2971,7 @@ qemuDomainUSBAddressAddHubs(virDomainDef *def)
         VIR_APPEND_ELEMENT(def->hubs, def->nhubs, hub);
     }
 
-    ret = 0;
-    VIR_FREE(hub);
-    return ret;
+    return 0;
 }