logging: make banner printing safer

Don't rely on the buffer filled with '=' characters to be always at
least as long as the log-specific banner string.

diff --git a/logging.c b/logging.c
index e12bad7f1b6bd094f0f2f2ca7f0ee817a2b2a9cf..1993ab724c16f3b7a2a73219c15eec3c10b392ea 100644 (file)
--- a/logging.c
+++ b/logging.c
@@ -289,7 +289,7 @@ LOG_FileWrite(LOG_FileID id, const char *format, ...)
     char bannerline[256];
     int i, bannerlen;
 
-    bannerlen = strlen(logfiles[id].banner);
+    bannerlen = MIN(strlen(logfiles[id].banner), sizeof (bannerline) - 1);
 
     for (i = 0; i < bannerlen; i++)
       bannerline[i] = '=';