]> git.ipfire.org Git - thirdparty/git.git/commitdiff
gitk: fix msgfmt being required
authorPatrick Steinhardt <ps@pks.im>
Thu, 5 Feb 2026 11:50:13 +0000 (12:50 +0100)
committerPatrick Steinhardt <ps@pks.im>
Thu, 5 Feb 2026 11:54:03 +0000 (12:54 +0100)
While the Meson build instructions already handle the case where msgfmt
wasn't found, we forgot to mark the dependency itself as optional. This
causes an error in case the executable could not be found:

  Project name: gitk
  Project version: undefined
  Program sh found: YES (C:\Program Files\Git\bin\sh.EXE)
  Program wish found: YES (C:\Program Files\Git\mingw64\bin\wish.EXE)
  Program chmod found: YES (C:\Program Files\Git\usr\bin\chmod.EXE)
  Program mv found: YES (C:\Program Files\Git\usr\bin\mv.EXE)
  Program sed found: YES (C:\Program Files\Git\usr\bin\sed.EXE)
  Program msgfmt found: NO

  subprojects\gitk\meson.build:28:3: ERROR: Program 'msgfmt' not found or not executable

Fix the issue by adding the `required: false` parameter.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
meson.build

index ca3c0cec5832478594d9e0cc07f5f044e3a920f3..aecc068d30ccc04c8b91aa7b820be116fc219eda 100644 (file)
@@ -25,6 +25,6 @@ custom_target(
   install_dir: get_option('bindir'),
 )
 
-if find_program('msgfmt').found()
+if find_program('msgfmt', required: false).found()
   subdir('po')
 endif