generated tests: avoid extra "FIXME" comments

* tests/gen-testsuite-part: Avoid putting too much "FIXME"
comments in the generated test scripts, since they end up
being just counter-productive noise when one has to grep
the test scripts looking for real "FIXME" items.

diff --git a/ChangeLog b/ChangeLog
index a97f07093291bcda09f85ee89609f81c19ff6e0a..71fde1131d7f7bfe1cd5d928e40ad1b6d0a9b2d6 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2011-11-05  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+       generated tests: avoid extra "FIXME" comments
+       * tests/gen-testsuite-part: Avoid putting too much "FIXME"
+       comments in the generated test scripts, since they end up
+       being just counter-productive noise when one has to grep
+       the test scripts looking for real "FIXME" items.
+
 2011-09-12  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
        cosmetics: fix typo in 'prove-runner' script

diff --git a/tests/gen-testsuite-part b/tests/gen-testsuite-part
index c547f4a1172e32f195d4947e705cb27e8766ee0e..6009dbc5464b4f89ccdf57cd0b478a5c47dea2a1 100755 (executable)
--- a/tests/gen-testsuite-part
+++ b/tests/gen-testsuite-part
@@ -84,10 +84,11 @@ sub line_match ($$)
 sub write_wrapper_script ($$$)
 {
   my ($file_handle, $wrapped_test, $shell_setup_code, $creator_name) = @_;
+  # FIXME: we use some creative quoting in the generated scripts,
+  # FIXME: to please maintainer-check.
   print $file_handle unindent <<EOF;
     #! /bin/sh
     # This file has been automatically generated.  DO NOT EDIT BY HAND!
-    # FIXME: creative quoting to please maintainer-check.
     . ./defs-static || exit '99';
     $shell_setup_code
     # In the spirit of VPATH, we prefer a test in the build tree
@@ -95,12 +96,10 @@ sub write_wrapper_script ($$$)
     for dir in . "\$testsrcdir"; do
       if test -f "\$dir/$wrapped_test"; then
         echo "\$0: will source \$dir/$wrapped_test"
-        # FIXME: creative quoting to please maintainer-check.
         . "\$dir/$wrapped_test"; exit "\$?"
       fi
     done
     echo "\$0: cannot find wrapped test \\`$wrapped_test'" >&2
-    # FIXME: creative quoting to please maintainer-check.
     exit '99'
 EOF
 }