Fix memory leak in ldns_pkt_rr_list_by_name()

The intermediate copy for section selection wasn't freed.

diff --git a/packet.c b/packet.c
index 7c42783163fb5840ae7ebd5de90a593ea9a05da8..54594ddeb4ddd6340214b2b67756300ea1cceadb 100644 (file)
--- a/packet.c
+++ b/packet.c
@@ -273,9 +273,15 @@ ldns_pkt_rr_list_by_name(ldns_pkt *packet,
                        if (ret == NULL) {
                                ret = ldns_rr_list_new();
                        }
-                       ldns_rr_list_push_rr(ret, ldns_rr_list_rr(rrs, i));
+                       ldns_rr_list_push_rr(ret,
+                                            ldns_rr_clone(
+                                               ldns_rr_list_rr(rrs, i))
+                                           );
                }
        }
+
+       ldns_rr_list_deep_free(rrs);
+
        return ret;
 }