Minor pppoe cleanup

cppcheck said:
[decode-pppoe.c:58] -> [decode-pppoe.c:60]: (performance, inconclusive) Variable 'pppoedh' is reassigned a value before the old one has been used if variable is no semaphore variable.

diff --git a/src/decode-pppoe.c b/src/decode-pppoe.c
index 7f49046b5d485ef68a4d8f4ccc546c29a247e067..83e2b0962325b3372ba70620b7ccc4da75170e36 100644 (file)
--- a/src/decode-pppoe.c
+++ b/src/decode-pppoe.c
@@ -55,7 +55,6 @@ void DecodePPPOEDiscovery(ThreadVars *tv, DecodeThreadVars *dtv, Packet *p, uint
         ENGINE_SET_EVENT(p, PPPOE_PKT_TOO_SMALL);
         return;
     }
-    p->pppoedh = NULL;
 
     p->pppoedh = (PPPOEDiscoveryHdr *)pkt;
     if (p->pppoedh == NULL)