]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm/amdgpu: Don't warn on destroying a pinned BO
authorMichel Dänzer <michel.daenzer@amd.com>
Thu, 19 Jul 2018 15:38:18 +0000 (17:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 15 Sep 2018 07:47:01 +0000 (09:47 +0200)
commit 456607d816d89a442a3d5ec98b02c8bc950b5228 upstream.

The warning turned out to be not so useful, as BO destruction tends to
be deferred to a workqueue.

Also, we should be preventing any damage from this now, so not really
important anymore to fix code doing this.

Acked-by: Alex Deucher <alexander.deucher@amd.com>
Tested-by: Mike Lothian <mike@fireburn.co.uk>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_object.c

index bd07e2d3589dbfaa1ef347e39272b8b621dcf0be..3873c3353020fdda645d1ac3f45d11b348925734 100644 (file)
@@ -76,7 +76,7 @@ static void amdgpu_ttm_bo_destroy(struct ttm_buffer_object *tbo)
        struct amdgpu_device *adev = amdgpu_ttm_adev(tbo->bdev);
        struct amdgpu_bo *bo = ttm_to_amdgpu_bo(tbo);
 
-       if (WARN_ON_ONCE(bo->pin_count > 0))
+       if (bo->pin_count > 0)
                amdgpu_bo_subtract_pin_size(bo);
 
        if (bo->kfd_bo)