]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: make virDomainDiskSourceFormatNetwork() void
authorMatt Coleman <mcoleman@datto.com>
Fri, 6 Nov 2020 03:32:45 +0000 (22:32 -0500)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Nov 2020 11:53:11 +0000 (12:53 +0100)
This function always returns zero, so it might as well be void.

Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/domain_conf.c

index 32fa01f2c4b6510f70597c28beedaa3e9c2a3507..9b3e2a5bcb0a5685bec7f4c2a62084533da7454f 100644 (file)
@@ -25317,7 +25317,7 @@ virDomainDiskSourceFormatNetworkCookies(virBufferPtr buf,
 }
 
 
-static int
+static void
 virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf,
                                  virBufferPtr childBuf,
                                  virStorageSourcePtr src,
@@ -25375,8 +25375,6 @@ virDomainDiskSourceFormatNetwork(virBufferPtr attrBuf,
 
     if (src->timeout)
         virBufferAsprintf(childBuf, "<timeout seconds='%llu'/>\n", src->timeout);
-
-    return 0;
 }
 
 
@@ -25488,9 +25486,7 @@ virDomainDiskSourceFormat(virBufferPtr buf,
         break;
 
     case VIR_STORAGE_TYPE_NETWORK:
-        if (virDomainDiskSourceFormatNetwork(&attrBuf, &childBuf,
-                                             src, flags) < 0)
-            return -1;
+        virDomainDiskSourceFormatNetwork(&attrBuf, &childBuf, src, flags);
         break;
 
     case VIR_STORAGE_TYPE_VOLUME: