]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Fix retval if ACL check fails in qemuNodeGetSecurityModel
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 21 Aug 2019 11:05:16 +0000 (13:05 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 4 Jan 2021 19:18:11 +0000 (20:18 +0100)
While previously we returned 0 this is not correct. We have to
return a negative value to indicate error.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/qemu/qemu_driver.c

index 96ec84bd1c20db508c2226d887c9175ea2c330b2..88324945ef361ae7b44a778f568636730b0dba0a 100644 (file)
@@ -5935,7 +5935,7 @@ static int qemuNodeGetSecurityModel(virConnectPtr conn,
     memset(secmodel, 0, sizeof(*secmodel));
 
     if (virNodeGetSecurityModelEnsureACL(conn) < 0)
-        return 0;
+        return -1;
 
     /* We treat no driver as success, but simply return no data in *secmodel */
     if (!(caps = virQEMUDriverGetCapabilities(driver, false)) ||