s3:registry: untangle assignment from check in reg_deletevalue()

Signed-off-by: Andreas Schneider <asn@samba.org>

diff --git a/source3/registry/reg_api.c b/source3/registry/reg_api.c
index 155fc96a5ffb306ef5fedb3bb50f8b9a554b19e6..20ece83075e16b623b3623762f24755cb72036af 100644 (file)
--- a/source3/registry/reg_api.c
+++ b/source3/registry/reg_api.c
@@ -802,7 +802,8 @@ WERROR reg_deletevalue(struct registry_key *key, const char *name)
                return WERR_ACCESS_DENIED;
        }
 
-       if (!W_ERROR_IS_OK(err = fill_value_cache(key))) {
+       err = fill_value_cache(key);
+       if (!W_ERROR_IS_OK(err)) {
                return err;
        }