]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: gadget: function: printer: Fix a memory leak for interface descriptor
authorZqiang <qiang.zhang@windriver.com>
Thu, 10 Dec 2020 02:01:48 +0000 (10:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Jan 2021 18:49:04 +0000 (19:49 +0100)
commit 2cc332e4ee4febcbb685e2962ad323fe4b3b750a upstream.

When printer driver is loaded, the printer_func_bind function is called, in
this function, the interface descriptor be allocated memory, if after that,
the error occurred, the interface descriptor memory need to be free.

Reviewed-by: Peter Chen <peter.chen@nxp.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Zqiang <qiang.zhang@windriver.com>
Link: https://lore.kernel.org/r/20201210020148.6691-1-qiang.zhang@windriver.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/gadget/function/f_printer.c

index d89b3046dd10b809fe28332541c2f29839d80fea..b962f24b500bfc28c3b6d15b176c7ad431005170 100644 (file)
@@ -1120,6 +1120,7 @@ fail_tx_reqs:
                printer_req_free(dev->in_ep, req);
        }
 
+       usb_free_all_descriptors(f);
        return ret;
 
 }