]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
do_sys_truncate(): switch to CLASS(filename)
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 11 Oct 2024 04:07:03 +0000 (00:07 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Fri, 16 Jan 2026 17:52:03 +0000 (12:52 -0500)
Note that failures from filename_lookup() are final - ESTALE returned
by it means that retry had been done by filename_lookup() and it failed
there.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/open.c

index bcaaf884e4367fae073a28396bb19518a6098452..34d9b1ecc1414b5fcd406ddb885f11d1ad0788d2 100644 (file)
--- a/fs/open.c
+++ b/fs/open.c
@@ -129,25 +129,23 @@ EXPORT_SYMBOL_GPL(vfs_truncate);
 int do_sys_truncate(const char __user *pathname, loff_t length)
 {
        unsigned int lookup_flags = LOOKUP_FOLLOW;
-       struct filename *name;
        struct path path;
        int error;
 
        if (length < 0) /* sorry, but loff_t says... */
                return -EINVAL;
 
-       name = getname(pathname);
+       CLASS(filename, name)(pathname);
 retry:
        error = filename_lookup(AT_FDCWD, name, lookup_flags, &path, NULL);
        if (!error) {
                error = vfs_truncate(&path, length);
                path_put(&path);
+               if (retry_estale(error, lookup_flags)) {
+                       lookup_flags |= LOOKUP_REVAL;
+                       goto retry;
+               }
        }
-       if (retry_estale(error, lookup_flags)) {
-               lookup_flags |= LOOKUP_REVAL;
-               goto retry;
-       }
-       putname(name);
        return error;
 }