]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Only build devstr when needs (attach PCI controller)
authorOsier Yang <jyang@redhat.com>
Sat, 4 Dec 2010 15:34:01 +0000 (23:34 +0800)
committerEric Blake <eblake@redhat.com>
Wed, 8 Dec 2010 15:58:51 +0000 (08:58 -0700)
- qemudDomainAttachPciControllerDevice: Don't build "devstr"
  if "-device" of qemu is not available, as "devstr" will only
  be used by "qemuMonitorAddDevice", which depends on "-device"
  argument of qemu is supported.

- "qemudDomainSaveImageOpen": Fix indent problem.

* src/qemu/qemu_driver.c

src/qemu/qemu_driver.c

index f5164e13274e50ba96d0afdc33707e2a0d5563b7..b640d23312814d03cf8968768e0ba53e9a2d6b3e 100644 (file)
@@ -6847,10 +6847,10 @@ static int qemudDomainSaveImageClose(int fd, pid_t read_pid, int *status)
 
 static int ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) ATTRIBUTE_NONNULL(5)
 qemudDomainSaveImageOpen(struct qemud_driver *driver,
-                                    const char *path,
-                                    virDomainDefPtr *ret_def,
-                                    struct qemud_save_header *ret_header,
-                                    pid_t *ret_read_pid)
+                         const char *path,
+                         virDomainDefPtr *ret_def,
+                         struct qemud_save_header *ret_header,
+                         pid_t *ret_read_pid)
 {
     int fd;
     pid_t read_pid = -1;
@@ -7905,11 +7905,11 @@ static int qemudDomainAttachPciControllerDevice(struct qemud_driver *driver,
             goto cleanup;
         if (qemuAssignDeviceControllerAlias(controller) < 0)
             goto cleanup;
-    }
 
-    if (!(devstr = qemuBuildControllerDevStr(controller))) {
-        virReportOOMError();
-        goto cleanup;
+        if (!(devstr = qemuBuildControllerDevStr(controller))) {
+            virReportOOMError();
+            goto cleanup;
+        }
     }
 
     if (VIR_REALLOC_N(vm->def->controllers, vm->def->ncontrollers+1) < 0) {