]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
misc: ad525x_dpot: Fix the enabling of the "otpXen" attributes
authorDan Bogdan Nechita <dan.bogdan.nechita@gmail.com>
Tue, 23 Feb 2016 09:48:45 +0000 (11:48 +0200)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 12 Oct 2017 14:28:17 +0000 (15:28 +0100)
commit 1bb850a1b7f68b66361e658e334f9fdf8231f17d upstream.

Currently writing the attributes with "echo" will result in comparing:
"enabled\n" with "enabled\0" and attribute is always set to false.

Use the sysfs_streq() instead because it treats both NUL and
new-line-then-NUL as equivalent string terminations.

Signed-off-by: Dan Bogdan Nechita <dan.bogdan.nechita@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/misc/ad525x_dpot.c

index 46272b0ae2dd4edd0bb5c2643fb8e4fce35d1102..6890e726b04f9962cec595b88ce6f4882c38ccdd 100644 (file)
@@ -457,7 +457,7 @@ static ssize_t sysfs_set_reg(struct device *dev,
        int err;
 
        if (reg & DPOT_ADDR_OTP_EN) {
-               if (!strncmp(buf, "enabled", sizeof("enabled")))
+               if (sysfs_streq(buf, "enabled"))
                        set_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);
                else
                        clear_bit(DPOT_RDAC_MASK & reg, data->otp_en_mask);