dnsupdates: clean up all RRSets and not only type A

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13706
BUG: https://bugzilla.samba.org/show_bug.cgi?id=14244

Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/lib/addns/dnsrecord.c b/lib/addns/dnsrecord.c
index 0d14937399719f790eb6ccb8c41a3df7994dba35..e6e205e6832cc9349c73e11b1f04980ee9e67542 100644 (file)
--- a/lib/addns/dnsrecord.c
+++ b/lib/addns/dnsrecord.c
@@ -430,10 +430,10 @@ DNS_ERROR dns_create_update_request(TALLOC_CTX *mem_ctx,
        if (!ERR_DNS_IS_OK(err)) goto error;
 
        /*
-        * Delete any existing A records
+        * Delete all existing RRsets from our name
         */
 
-       err = dns_create_delete_record(req, hostname, QTYPE_A, DNS_CLASS_ANY,
+       err = dns_create_delete_record(req, hostname, QTYPE_ANY, DNS_CLASS_ANY,
                                       &rec);
        if (!ERR_DNS_IS_OK(err)) goto error;
 

diff --git a/selftest/knownfail b/selftest/knownfail
index 6f9bf3e6e76d13dbf3956de848123433c7d2b70a..6c005d1f4deb7afc6db6269b44e5d59870d5710a 100644 (file)
--- a/selftest/knownfail
+++ b/selftest/knownfail
@@ -396,4 +396,3 @@
 ^samba.tests.ntlmdisabled.python\(ktest\).python2.ntlmdisabled.NtlmDisabledTests.test_samr_change_password\(ktest\)
 ^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).python3.ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ad_dc_no_ntlm\)
 ^samba.tests.ntlmdisabled.python\(ad_dc_no_ntlm\).python2.ntlmdisabled.NtlmDisabledTests.test_ntlm_connection\(ad_dc_no_ntlm\)
-^samba4.blackbox.net_ads_dns