]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
drm: xlnx: zynqmp: fix a memset in zynqmp_dp_train()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 30 Mar 2021 09:31:52 +0000 (12:31 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 08:49:56 +0000 (10:49 +0200)
[ Upstream commit 5842ab76bbfadb37eaea91e53c1efe34ae504e4a ]

The dp->train_set[] for this driver is only two characters, not four so
this memsets too much.  Fortunately, this ends up corrupting a struct
hole and not anything important.

Fixes: d76271d22694 ("drm: xlnx: DRM/KMS driver for Xilinx ZynqMP DisplayPort Subsystem")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/YGLwCBMotnrKZu6P@mwanda
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/xlnx/zynqmp_dp.c

index 99158ee67d02b7a8d0bb4b3684fcbc5ac11a0755..59d1fb017da0109d1575cb2181808d75ca723e39 100644 (file)
@@ -866,7 +866,7 @@ static int zynqmp_dp_train(struct zynqmp_dp *dp)
                return ret;
 
        zynqmp_dp_write(dp, ZYNQMP_DP_SCRAMBLING_DISABLE, 1);
-       memset(dp->train_set, 0, 4);
+       memset(dp->train_set, 0, sizeof(dp->train_set));
        ret = zynqmp_dp_link_train_cr(dp);
        if (ret)
                return ret;