]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: rockchip: Update the PinePhone Pro panel description
authorOlivier Benjamin <olivier.benjamin@bootlin.com>
Thu, 19 Jun 2025 13:41:24 +0000 (15:41 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 19 Jun 2025 20:02:00 +0000 (22:02 +0200)
Fix a few issues in the panel section of the PinePhone Pro DTS:
  - add the second part of the Himax HX8394 LCD panel controller
    compatible
  - as proposed by Diederik de Haas, reuse the mipi_out and ports
    definitions from rk3399-base.dtsi instead of redefining them
  - add a pinctrl for the LCD_RST signal for LCD1, derived from
    LCD1_RST, which is on GPIO4_D1, as documented on pages 11
    and 16 of the PinePhone Pro schematic

Signed-off-by: Olivier Benjamin <olivier.benjamin@bootlin.com>
Reviewed-by: Diederik de Haas <didi.debian@cknow.org>
Link: https://lore.kernel.org/r/20250619-dtb_fixes-v3-1-9cb02ddd8ce4@bootlin.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts

index 04ba4c4565d0a205e2e46d7535c6a3190993621d..909ed14035f783fd14362f4e3a9a3fe3b50d5937 100644 (file)
 };
 
 &mipi_dsi {
-       status = "okay";
        clock-master;
-
-       ports {
-               mipi_out: port@1 {
-                       #address-cells = <0>;
-                       #size-cells = <0>;
-                       reg = <1>;
-
-                       mipi_out_panel: endpoint {
-                               remote-endpoint = <&mipi_in_panel>;
-                       };
-               };
-       };
+       status = "okay";
 
        panel@0 {
-               compatible = "hannstar,hsd060bhw4";
+               compatible = "hannstar,hsd060bhw4", "himax,hx8394";
                reg = <0>;
                backlight = <&backlight>;
-               reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
-               vcc-supply = <&vcc2v8_lcd>;
                iovcc-supply = <&vcc1v8_lcd>;
                pinctrl-names = "default";
+               pinctrl-0 = <&lcd1_rst_pin>;
+               reset-gpios = <&gpio4 RK_PD1 GPIO_ACTIVE_LOW>;
+               vcc-supply = <&vcc2v8_lcd>;
 
                port {
                        mipi_in_panel: endpoint {
        };
 };
 
+&mipi_out {
+       mipi_out_panel: endpoint {
+               remote-endpoint = <&mipi_in_panel>;
+       };
+};
+
 &pmu_io_domains {
        pmu1830-supply = <&vcc_1v8>;
        status = "okay";
                };
        };
 
+       lcd {
+               lcd1_rst_pin: lcd1-rst-pin {
+                       rockchip,pins = <4 RK_PD1 RK_FUNC_GPIO &pcfg_pull_none>;
+               };
+       };
+
        leds {
                red_led_pin: red-led-pin {
                        rockchip,pins = <4 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>;