]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
libstdc++: Fix mem-initializer in std::move_only_function [PR102825]
authorJonathan Wakely <jwakely@redhat.com>
Tue, 19 Oct 2021 08:16:56 +0000 (09:16 +0100)
committerJonathan Wakely <jwakely@redhat.com>
Tue, 19 Oct 2021 10:50:46 +0000 (11:50 +0100)
libstdc++-v3/ChangeLog:

PR libstdc++/102825
* include/bits/mofunc_impl.h (move_only_function): Remove
invalid base initializer.
* testsuite/20_util/move_only_function/cons.cc: Instantiate
constructors to check bodies.

libstdc++-v3/include/bits/mofunc_impl.h
libstdc++-v3/testsuite/20_util/move_only_function/cons.cc

index 543c6f547b70b529c8a0bc17e2ee921008ef2b9a..968d235f8676de8ba212573fc4bf6e5c51210928 100644 (file)
@@ -108,7 +108,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
        move_only_function(in_place_type_t<_Tp>, initializer_list<_Up> __il,
                           _Args&&... __args)
        noexcept(_S_nothrow_init<_Tp, initializer_list<_Up>&, _Args...>())
-       : _Mofunc_base(nullptr), _M_invoke(&_S_invoke<_Tp>)
+       : _M_invoke(&_S_invoke<_Tp>)
        {
          static_assert(is_same_v<decay_t<_Tp>, _Tp>);
          _M_init<_Tp>(__il, std::forward<_Args>(__args)...);
index 0992f1070038344c0310198cbbec2b62ca2b85de..d8a0a4ab2b0ca3d4549094d62728a63d12f3f1a3 100644 (file)
@@ -96,3 +96,30 @@ static_assert( ! is_nothrow_constructible_v<move_only_function<void() noexcept>,
                                            in_place_type_t<H>, int> );
 static_assert( is_nothrow_constructible_v<move_only_function<void() noexcept>,
                                          in_place_type_t<H>, int, int> );
+
+struct I {
+  I(int, const char*);
+  I(std::initializer_list<char>);
+  int operator()() const noexcept;
+};
+
+static_assert( is_constructible_v<move_only_function<void()>,
+                                 std::in_place_type_t<I>,
+                                 int, const char*> );
+static_assert( is_constructible_v<move_only_function<void()>,
+                                 std::in_place_type_t<I>,
+                                 std::initializer_list<char>> );
+
+void
+test_instantiation()
+{
+  // Instantiate the constructor bodies
+  move_only_function<void()> f0;
+  move_only_function<void()> f1(nullptr);
+  move_only_function<void()> f2( I(1, "two") );
+  move_only_function<void()> f3(std::in_place_type<I>, 3, "four");
+  move_only_function<void()> f4(std::in_place_type<I>, // PR libstdc++/102825
+                               { 'P', 'R', '1', '0', '2', '8', '2', '5'});
+  auto f5 = std::move(f4);
+  f4 = std::move(f5);
+}