]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/core/loader: Free the image file descriptor on error
authorAlistair Francis <alistair.francis@wdc.com>
Thu, 30 Oct 2025 01:53:05 +0000 (11:53 +1000)
committerAlistair Francis <alistair.francis@wdc.com>
Fri, 9 Jan 2026 05:01:09 +0000 (15:01 +1000)
Coverity: CID 1642764
Fixes: f62226f7dc4 ("hw/core/loader: improve error handling in image loading functions")
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Vishal Chourasia <vishalc@linux.ibm.com>
Message-ID: <20251030015306.2279148-2-alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/core/loader.c

index b7638ccd7206dde09e44f9cdaf7808d2b6ae9ce6..3d2c1ae286b118e38dd2e9fb1cae9c4341413a52 100644 (file)
@@ -86,6 +86,7 @@ int64_t get_image_size(const char *filename, Error **errp)
 
     if (size < 0) {
         error_setg_errno(errp, errno, "lseek failure: %s", filename);
+        close(fd);
         return -1;
     }