]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainSnapshotAlignDisks: remove unnecessary 'tmp' variable
authorPeter Krempa <pkrempa@redhat.com>
Mon, 21 Sep 2020 16:58:37 +0000 (18:58 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 23 Sep 2020 20:38:49 +0000 (22:38 +0200)
The converted string is used exactly once so we can call the conversion
without storing the result in a variable.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/snapshot_conf.c

index aeebe2fb33ba13c23deff8623a99ddc438c24de7..10eb584a1c7de9d28da6903be68eb3817e48ce28 100644 (file)
@@ -709,12 +709,10 @@ virDomainSnapshotAlignDisks(virDomainSnapshotDefPtr snapdef,
                    snapdisk->snapshot != default_snapshot &&
                    !(snapdisk->snapshot == VIR_DOMAIN_SNAPSHOT_LOCATION_NONE &&
                      disk_snapshot == VIR_DOMAIN_SNAPSHOT_LOCATION_NONE)) {
-            const char *tmp;
-
-            tmp = virDomainSnapshotLocationTypeToString(default_snapshot);
             virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                            _("disk '%s' must use snapshot mode '%s'"),
-                           snapdisk->name, tmp);
+                           snapdisk->name,
+                           virDomainSnapshotLocationTypeToString(default_snapshot));
             return -1;
         }
         if (snapdisk->src->path &&