]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: add missing READ_ONCE(sk->sk_sndbuf) annotation
authorEric Dumazet <edumazet@google.com>
Fri, 28 Jul 2023 15:03:13 +0000 (15:03 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Aug 2023 13:13:51 +0000 (15:13 +0200)
[ Upstream commit 74bc084327c643499474ba75df485607da37dd6e ]

In a prior commit, I forgot to change sk_getsockopt()
when reading sk->sk_sndbuf locklessly.

Fixes: e292f05e0df7 ("tcp: annotate sk->sk_sndbuf lockless reads")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/core/sock.c

index ffd566d52eec397681ff672ba170ca8629e29450..0e480ac6c4de523ee5b512696a0b647676a8f911 100644 (file)
@@ -1456,7 +1456,7 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
                break;
 
        case SO_SNDBUF:
-               v.val = sk->sk_sndbuf;
+               v.val = READ_ONCE(sk->sk_sndbuf);
                break;
 
        case SO_RCVBUF: