]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
testutilsxen: Avoid double free of driver caps
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Dec 2019 09:17:30 +0000 (10:17 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 18 Dec 2019 13:28:48 +0000 (14:28 +0100)
In testXLInitDriver() a dummy driver structure is filled and it
is freed later in testXLFreeDriver(). However, it is sufficient
to unref just driver->config because that results in
libxlDriverConfigDispose() being called which unrefs
driver->config->caps. There is no need to unref it again in
testXLFreeDriver() - in fact it's undesired.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
tests/testutilsxen.c

index 75cd42ec435f551822c6649a38870946a25ee8b6..b73c79581d7212ec4487d1f1c79b0fccc24eeab8 100644 (file)
@@ -105,7 +105,6 @@ libxlDriverPrivatePtr testXLInitDriver(void)
 
 void testXLFreeDriver(libxlDriverPrivatePtr driver)
 {
-    virObjectUnref(driver->config->caps);
     virObjectUnref(driver->config);
     virObjectUnref(driver->xmlopt);
     virMutexDestroy(&driver->lock);