]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
c-family: Let libcpp know when the compilation is for a PCH [PR9471]
authorLewis Hyatt <lhyatt@gmail.com>
Fri, 10 Nov 2023 16:10:18 +0000 (11:10 -0500)
committerLewis Hyatt <lhyatt@gmail.com>
Tue, 14 Nov 2023 22:50:42 +0000 (17:50 -0500)
libcpp will generate diagnostics when it encounters things in the main file
that only belong in a header file, such as `#pragma once' or `#pragma GCC
system_header'. But sometimes the main file is a header file that is just
being compiled separately, e.g. to produce a C++ module or a PCH, in which
case such diagnostics should be suppressed. libcpp already has an interface
to request that, so make use of it in the C frontends to prevent libcpp from
issuing unwanted diagnostics when compiling a PCH.

gcc/c-family/ChangeLog:

PR pch/9471
PR pch/47857
* c-opts.cc (c_common_post_options): Set cpp_opts->main_search
so libcpp knows it is compiling a header file separately.

gcc/testsuite/ChangeLog:

PR pch/9471
PR pch/47857
* g++.dg/pch/main-file-warnings.C: New test.
* g++.dg/pch/main-file-warnings.Hs: New test.
* gcc.dg/pch/main-file-warnings.c: New test.
* gcc.dg/pch/main-file-warnings.hs: New test.

gcc/c-family/c-opts.cc
gcc/testsuite/g++.dg/pch/main-file-warnings.C [new file with mode: 0644]
gcc/testsuite/g++.dg/pch/main-file-warnings.Hs [new file with mode: 0644]
gcc/testsuite/gcc.dg/pch/main-file-warnings.c [new file with mode: 0644]
gcc/testsuite/gcc.dg/pch/main-file-warnings.hs [new file with mode: 0644]

index fbabd1816c18cf678018e46fec139809883504c4..10403c03bd6e902cd97eddef463a8743a6378e0d 100644 (file)
@@ -1174,6 +1174,9 @@ c_common_post_options (const char **pfilename)
                       "the %qs debug info cannot be used with "
                       "pre-compiled headers",
                       debug_set_names (write_symbols & ~DWARF2_DEBUG));
+         /* Let libcpp know that the main file is a header so it won't
+            complain about things like #include_next and #pragma once.  */
+         cpp_opts->main_search = CMS_header;
        }
       else if (write_symbols != NO_DEBUG && write_symbols != DWARF2_DEBUG)
        c_common_no_more_pch ();
diff --git a/gcc/testsuite/g++.dg/pch/main-file-warnings.C b/gcc/testsuite/g++.dg/pch/main-file-warnings.C
new file mode 100644 (file)
index 0000000..a9e8b0b
--- /dev/null
@@ -0,0 +1,7 @@
+/* PR pch/9471 */
+/* PR pch/47857 */
+/* Test will fail if any warnings get issued while compiling the header into a PCH.  */
+#include "main-file-warnings.H"
+#pragma once /* { dg-warning "in main file" } */
+#pragma GCC system_header /* { dg-warning "outside include file" } */
+#include_next <stdint.h> /* { dg-warning "in primary source file" } */
diff --git a/gcc/testsuite/g++.dg/pch/main-file-warnings.Hs b/gcc/testsuite/g++.dg/pch/main-file-warnings.Hs
new file mode 100644 (file)
index 0000000..d1582bb
--- /dev/null
@@ -0,0 +1,3 @@
+#pragma once /* { dg-bogus "in main file" } */
+#pragma GCC system_header /* { dg-bogus "outside include file" } */
+#include_next <stdint.h> /* { dg-bogus "in primary source file" } */
diff --git a/gcc/testsuite/gcc.dg/pch/main-file-warnings.c b/gcc/testsuite/gcc.dg/pch/main-file-warnings.c
new file mode 100644 (file)
index 0000000..aedbc15
--- /dev/null
@@ -0,0 +1,7 @@
+/* PR pch/9471 */
+/* PR pch/47857 */
+/* Test will fail if any warnings get issued while compiling the header into a PCH.  */
+#include "main-file-warnings.h"
+#pragma once /* { dg-warning "in main file" } */
+#pragma GCC system_header /* { dg-warning "outside include file" } */
+#include_next <stdint.h> /* { dg-warning "in primary source file" } */
diff --git a/gcc/testsuite/gcc.dg/pch/main-file-warnings.hs b/gcc/testsuite/gcc.dg/pch/main-file-warnings.hs
new file mode 100644 (file)
index 0000000..d1582bb
--- /dev/null
@@ -0,0 +1,3 @@
+#pragma once /* { dg-bogus "in main file" } */
+#pragma GCC system_header /* { dg-bogus "outside include file" } */
+#include_next <stdint.h> /* { dg-bogus "in primary source file" } */