]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: report enum errors in virDomainInputDefValidate
authorJán Tomko <jtomko@redhat.com>
Tue, 21 Aug 2018 12:53:55 +0000 (14:53 +0200)
committerJán Tomko <jtomko@redhat.com>
Tue, 28 Aug 2018 10:55:42 +0000 (12:55 +0200)
Commit deb057f added a switch without a default case.
Add it and call virReportEnumRangeError for _LAST too.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
src/conf/domain_conf.c

index bde9fef9148237a8aa89bc892bfd18ad6faba9b5..8cb28a088055fc180a4e90b1828d3b27e6b9bc7e 100644 (file)
@@ -5760,7 +5760,6 @@ virDomainInputDefValidate(const virDomainInputDef *input)
         case VIR_DOMAIN_INPUT_TYPE_MOUSE:
         case VIR_DOMAIN_INPUT_TYPE_TABLET:
         case VIR_DOMAIN_INPUT_TYPE_KBD:
-        case VIR_DOMAIN_INPUT_TYPE_LAST:
             if (input->source.evdev) {
                  virReportError(VIR_ERR_XML_ERROR, "%s",
                                 _("setting source evdev path only supported for "
@@ -5771,6 +5770,11 @@ virDomainInputDefValidate(const virDomainInputDef *input)
 
         case VIR_DOMAIN_INPUT_TYPE_PASSTHROUGH:
             break;
+
+        case VIR_DOMAIN_INPUT_TYPE_LAST:
+        default:
+            virReportEnumRangeError(virDomainInputType, input->type);
+            return -1;
     }
 
     return 0;