]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mpls: add missing unregister_netdevice_notifier to mpls_init
authorSabrina Dubroca <sd@queasysnail.net>
Wed, 11 Mar 2026 22:35:09 +0000 (23:35 +0100)
committerJakub Kicinski <kuba@kernel.org>
Fri, 13 Mar 2026 02:25:59 +0000 (19:25 -0700)
If mpls_init() fails after registering mpls_dev_notifier, it never
gets removed. Add the missing unregister_netdevice_notifier() call to
the error handling path.

Fixes: 5be2062e3080 ("mpls: Handle error of rtnl_register_module().")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Link: https://patch.msgid.link/7c55363c4f743d19e2306204a134407c90a69bbb.1773228081.git.sd@queasysnail.net
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mpls/af_mpls.c

index ef9e749d5e08f4c04e97b2b2182a67329c04d343..d5417688f69e6316fa368f05843d814cb648dbca 100644 (file)
@@ -2854,6 +2854,7 @@ out_unregister_rtnl_af:
        rtnl_af_unregister(&mpls_af_ops);
 out_unregister_dev_type:
        dev_remove_pack(&mpls_packet_type);
+       unregister_netdevice_notifier(&mpls_dev_notifier);
 out_unregister_pernet:
        unregister_pernet_subsys(&mpls_net_ops);
        goto out;