]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
No need for if
authorArran Cudbard-Bell <a.cudbardb@freeradius.org>
Fri, 11 Sep 2015 17:04:31 +0000 (18:04 +0100)
committerArran Cudbard-Bell <a.cudbardb@freeradius.org>
Fri, 11 Sep 2015 17:05:08 +0000 (18:05 +0100)
Confusing because the rest of the frees don't use a condition

src/main/pair.c

index 670e12206e78b73885b57efffe397666d7cdbb4b..c893b1ef3ed66bf06fca6b82aacafcdcb168654f 100644 (file)
@@ -95,7 +95,7 @@ int radius_compare_vps(UNUSED REQUEST *request, VALUE_PAIR *check, VALUE_PAIR *v
                        REDEBUG("Error stringifying operand for regular expression");
 
                regex_error:
-                       if (preg) talloc_free(preg);
+                       talloc_free(preg);
                        talloc_free(expr);
                        talloc_free(value);
                        return -2;