maintainer check: quote literal `$' in Makefile rule

* Makefile.am (sc_tests_PATH_SEPARATOR): Escape literal `$'
character in double-quoted string.  Fix a bug in which the rule
emitted an erroneously empty substring in its error message.

diff --git a/ChangeLog b/ChangeLog
index 6855f9af211f0c3db5463e297c6d2bfcf82d466d..0ef2910138c9abd4ab796d6e0960a0b17fb217eb 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2011-04-14  Stefano Lattarini  <stefano.lattarini@gmail.com>
+
+       maintainer check: quote literal `$' in Makefile rule
+       * Makefile.am (sc_tests_PATH_SEPARATOR): Escape literal `$'
+       character in double-quoted string.  Fix a bug in which the rule
+       emitted an erroneously empty substring in its error message.
+
 2010-09-25  Stefano Lattarini  <stefano.lattarini@gmail.com>
 
        Testsuite: Use `$PATH_SEPARATOR', not `:', when extending PATH.

diff --git a/Makefile.am b/Makefile.am
index d19d974be146d7655c6d6d4ad1f966828b401d49..de0bb735f416ea58cd125c44f5fcd74752c17129 100644 (file)
--- a/Makefile.am
+++ b/Makefile.am
@@ -413,7 +413,7 @@ sc_tests_plain_egrep_fgrep:
 ## Using `:' as a PATH separator is not portable.
 sc_tests_PATH_SEPARATOR:
        @if grep -E '\bPATH=.*:.*' $(srcdir)/tests/*.test ; then \
-         echo "Use \`$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \
+         echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \
          exit 1; \
        fi
 

diff --git a/Makefile.in b/Makefile.in
index 649565b0154695b6fa7786391cb0080d861e2033..c9a5bd92667c29cd0d9f8dd30bdc4c6dba8bf735 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -1093,7 +1093,7 @@ sc_tests_plain_egrep_fgrep:
 
 sc_tests_PATH_SEPARATOR:
        @if grep -E '\bPATH=.*:.*' $(srcdir)/tests/*.test ; then \
-         echo "Use \`$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \
+         echo "Use \`\$$PATH_SEPARATOR', not \`:', in PATH definitions above." 1>&2; \
          exit 1; \
        fi