]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
tools/power/x86/intel-speed-select: Fix off by one check
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 18 Jul 2022 13:17:17 +0000 (16:17 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:41:54 +0000 (14:41 +0200)
[ Upstream commit d9f74d98bbec978edbf860f729b531281ba0d8ff ]

Change > MAX_DIE_PER_PACKAGE to >= MAX_DIE_PER_PACKAGE to prevent
accessing one element beyond the end of the array.

Fixes: 7fd786dfbd2c ("tools/power/x86/intel-speed-select: OOB daemon mode")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
tools/power/x86/intel-speed-select/isst-daemon.c

index dd372924bc8266c0d1fd46c8bbca51bedd5c33c1..d0400c6684ba93f82bc5e9b9c51dec3ef1568c05 100644 (file)
@@ -41,7 +41,7 @@ void process_level_change(int cpu)
        time_t tm;
        int ret;
 
-       if (pkg_id >= MAX_PACKAGE_COUNT || die_id > MAX_DIE_PER_PACKAGE) {
+       if (pkg_id >= MAX_PACKAGE_COUNT || die_id >= MAX_DIE_PER_PACKAGE) {
                debug_printf("Invalid package/die info for cpu:%d\n", cpu);
                return;
        }