Succeed if make check does not report any errors

The conditional that evaluates if there are any FAILed test cases
currently always fails, since we ensure it fails if we find any
unexpected results in tests.sum and it would obviously fail if it does
not find failed results in tests.sum.  This patch fixes this by simply
inverting the result of the egrep, i.e. succeed if egrep fails (to
find failed results) and fail if it succeeds.

Tested with 'make subdirs=localedata check' and 'make subdirs=locale
check' where all tests succeed and with 'make subdirs=elf check' where
a couple of tests fail for me.

	 * Makefile (summarize-tests): Fix return value on success.

diff --git a/ChangeLog b/ChangeLog
index 68254a9a3de486767787b59c933f45f923c9417a..1ec13ba982dc2c95c4e5369f8fe8fb320cc80c09 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,7 @@
 2015-05-19  Siddhesh Poyarekar  <siddhesh@redhat.com>
 
+       * Makefile (summarize-tests): Fix return value on success.
+
        * manual/string.texi (Envz Functions): Add envz_remove.
 
 2015-05-18  Roland McGrath  <roland@hack.frob.com>

diff --git a/Makefile b/Makefile
index 7edf517724fc2e78eaf2177670ced61d7636f107..658ccfa037fc7a750fe0cc44867a7d8d95942f13 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -320,7 +320,7 @@ define summarize-tests
 @egrep -v '^(PASS|XFAIL):' $(objpfx)$1 || true
 @echo "Summary of test results$2:"
 @sed 's/:.*//' < $(objpfx)$1 | sort | uniq -c
-@egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1 && false
+@! egrep -q -v '^(X?PASS|XFAIL|UNSUPPORTED):' $(objpfx)$1
 endef
 
 tests-special-notdir = $(patsubst $(objpfx)%, %, $(tests-special))