lib-storage: Fix error logging for failing to create .vsize.lock

diff --git a/src/lib-storage/index/index-mailbox-size.c b/src/lib-storage/index/index-mailbox-size.c
index 85211584ab23f1f2116b45fd2d0183e17517de32..19a5051f98c16512d9268b09f91bd780929f8af1 100644 (file)
--- a/src/lib-storage/index/index-mailbox-size.c
+++ b/src/lib-storage/index/index-mailbox-size.c
@@ -150,9 +150,12 @@ static bool vsize_update_lock_full(struct mailbox_vsize_update *update,
        update->lock_fd = file_create_locked(update->lock_path, &set,
                                             &update->lock, &created, &error);
        if (update->lock_fd == -1) {
+               /* don't log lock timeouts, because we're somewhat expecting
+                  them. Especially when lock_secs is 0. */
                if (errno != EAGAIN) {
-                       i_error("file_create_locked(%s) failed: %m",
-                               update->lock_path);
+                       mail_storage_set_critical(box->storage,
+                               "file_create_locked(%s) failed: %s",
+                               update->lock_path, error);
                }
                return FALSE;
        }