Fix resolver responses statistics counter

The resquery_response() function increases the response counter without
checking if the response was successful. Increase the counter only when
the result indicates success.

(cherry picked from commit 12e7dfa397c92807bdc4e6f55918d46eb15e0600)

diff --git a/lib/dns/resolver.c b/lib/dns/resolver.c
index 4d3491c4a9e5b94d93851148e9f10b60b74b5482..f8536e6f580ce6180bf424bb5fbfc45b66818636 100644 (file)
--- a/lib/dns/resolver.c
+++ b/lib/dns/resolver.c
@@ -7943,12 +7943,12 @@ resquery_response(isc_result_t eresult, isc_region_t *region, void *arg) {
                if (result == ISC_R_COMPLETE) {
                        return;
                }
-       }
-
-       if (isc_sockaddr_pf(&query->addrinfo->sockaddr) == PF_INET) {
-               inc_stats(fctx->res, dns_resstatscounter_responsev4);
-       } else {
-               inc_stats(fctx->res, dns_resstatscounter_responsev6);
+       } else if (eresult == ISC_R_SUCCESS) {
+               if (isc_sockaddr_pf(&query->addrinfo->sockaddr) == PF_INET) {
+                       inc_stats(fctx->res, dns_resstatscounter_responsev4);
+               } else {
+                       inc_stats(fctx->res, dns_resstatscounter_responsev6);
+               }
        }
 
        rctx_respinit(query, fctx, eresult, region, &rctx);