udf: Limit sparing table size

[ Upstream commit 44ac6b829c4e173fdf6df18e6dd86aecf9a3dc99 ]

Although UDF standard allows it, we don't support sparing table larger
than a single block. Check it during mount so that we don't try to
access memory beyond end of buffer.

Reported-by: syzbot+9991561e714f597095da@syzkaller.appspotmail.com
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/fs/udf/super.c b/fs/udf/super.c
index f747bf72edbe05b52851fc89f5e40988e06ad147..a6ce0ddb392c71b5e483b529a572de468c005a21 100644 (file)
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1353,6 +1353,12 @@ static int udf_load_sparable_map(struct super_block *sb,
                        (int)spm->numSparingTables);
                return -EIO;
        }
+       if (le32_to_cpu(spm->sizeSparingTable) > sb->s_blocksize) {
+               udf_err(sb, "error loading logical volume descriptor: "
+                       "Too big sparing table size (%u)\n",
+                       le32_to_cpu(spm->sizeSparingTable));
+               return -EIO;
+       }
 
        for (i = 0; i < spm->numSparingTables; i++) {
                loc = le32_to_cpu(spm->locSparingTable[i]);