]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: fix stainfo check in rtw_aes_decrypt
authorMaksym Pikhotskyi <mpikhotskyi@gmail.com>
Fri, 17 Apr 2026 09:54:51 +0000 (13:54 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 May 2026 14:15:40 +0000 (16:15 +0200)
The null-pointer-guard was incorrect, returning _FAIL on valid pointer.
Invert the guard, so it returns _FAIL on invalid pointer.

Fixes: e23ad1570028 ("staging: rtl8723bs: use guard clause for stainfo check")
Reported-by: Luka Gejak <luka.gejak@linux.dev>
Closes: https://lore.kernel.org/linux-staging/E4BF62EF-C6F6-431F-8EDC-77C1E613E66B@linux.dev/
Reviewed-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Maksym Pikhotskyi <mpikhotskyi@gmail.com>
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Link: https://patch.msgid.link/20260417095452.23440-1-mpikhotskyi@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_security.c

index a00504ff2910982d16854f539d8f8e0738e6e446..f467cb5b1dca39010b6d8d6806949a6af85c0984 100644 (file)
@@ -1212,7 +1212,7 @@ u32 rtw_aes_decrypt(struct adapter *padapter, u8 *precvframe)
        if (prxattrib->encrypt != _AES_)
                return _SUCCESS;
        stainfo = rtw_get_stainfo(&padapter->stapriv, &prxattrib->ta[0]);
-       if (stainfo)
+       if (!stainfo)
                return _FAIL;
        if (is_multicast_ether_addr(prxattrib->ra)) {
                static unsigned long start;