]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib: libsmbclient: Ensure cli_rename() always sets cli->raw_status.
authorJeremy Allison <jra@samba.org>
Wed, 2 Feb 2022 18:52:09 +0000 (10:52 -0800)
committerJule Anger <janger@samba.org>
Sun, 6 Feb 2022 12:39:25 +0000 (12:39 +0000)
Identical change as used in cli_unlink(), cli_mkdir(), cli_rmdir()
cli_chkpath() to ensure SMB2 calls correctly set raw_status for
libsmbclient uses.

Remove knownfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14938

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Feb  2 21:50:31 UTC 2022 on sn-devel-184

(cherry picked from commit ca60f6350d566b7ecc822bcbb44fb65a1d150bbe)

Autobuild-User(v4-14-test): Jule Anger <janger@samba.org>
Autobuild-Date(v4-14-test): Sun Feb  6 12:39:25 UTC 2022 on sn-devel-184

selftest/knownfail.d/libsmbclient_rename [deleted file]
source3/libsmb/clifile.c

diff --git a/selftest/knownfail.d/libsmbclient_rename b/selftest/knownfail.d/libsmbclient_rename
deleted file mode 100644 (file)
index 88343b7..0000000
+++ /dev/null
@@ -1 +0,0 @@
-^samba4.libsmbclient.rename.SMB3.rename\(nt4_dc\)
index c619b009ec4732f41072fb5a35cc237f24002428..1028514da08ecf65d6e9136d379642d33ce5e298 100644 (file)
@@ -1489,6 +1489,7 @@ NTSTATUS cli_rename(struct cli_state *cli,
        }
 
        status = cli_rename_recv(req);
+       cli->raw_status = status; /* cli_smb2_rename_recv doesn't set this */
 
  fail:
        TALLOC_FREE(frame);