CVE-2015-5370: s4:rpc_server: remove pointless dcesrv_find_context() from dcesrv_bind()

BIND is the first pdu, which means the list of contexts is always empty.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11344

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>

diff --git a/source4/rpc_server/dcerpc_server.c b/source4/rpc_server/dcerpc_server.c
index 6587318cdadc40400986606abbef039b0c9b9e33..7721bc1f68183220e4d12e910f61f11280f76af6 100644 (file)
--- a/source4/rpc_server/dcerpc_server.c
+++ b/source4/rpc_server/dcerpc_server.c
@@ -726,12 +726,6 @@ static NTSTATUS dcesrv_bind(struct dcesrv_call_state *call)
        }
 
        context_id = call->pkt.u.bind.ctx_list[0].context_id;
-
-       /* you can't bind twice on one context */
-       if (dcesrv_find_context(call->conn, context_id) != NULL) {
-               return dcesrv_bind_nak(call, 0);
-       }
-
        if_version = call->pkt.u.bind.ctx_list[0].abstract_syntax.if_version;
        uuid = call->pkt.u.bind.ctx_list[0].abstract_syntax.uuid;