Although the value stored to 'v' is used in the enclosing expression,

the value is never actually read from 'v'

Found by Clang Static Analyzer.

SVN-Revision: 1623

diff --git a/libarchive/archive_write_set_format_cpio.c b/libarchive/archive_write_set_format_cpio.c
index 4457496d1515fb1a3a604910ebcfa40907449e2f..4becb21cfa726d5c613ac59cecc76ffb202b08a7 100644 (file)
--- a/libarchive/archive_write_set_format_cpio.c
+++ b/libarchive/archive_write_set_format_cpio.c
@@ -222,7 +222,7 @@ format_octal_recursive(int64_t v, char *p, int s)
                return (v);
        v = format_octal_recursive(v, p+1, s-1);
        *p = '0' + (v & 7);
-       return (v >>= 3);
+       return (v >> 3);
 }
 
 static int