]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
octeontx2-pf: Add tracepoint for NIX_PARSE_S
authorSubbaraya Sundeep <sbhatta@marvell.com>
Thu, 15 May 2025 17:44:08 +0000 (23:14 +0530)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 20 May 2025 10:37:37 +0000 (12:37 +0200)
The NIX_PARSE_S structure populated by hardware in the
NIX RX CQE has parsing information for the received packet.
A tracepoint to dump the all words of NIX_PARSE_S
is helpful in debugging packet parser.

Signed-off-by: Subbaraya Sundeep <sbhatta@marvell.com>
Signed-off-by: Ratheesh Kannoth <rkannoth@marvell.com>
Link: https://patch.msgid.link/1747331048-15347-1-git-send-email-sbhatta@marvell.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.c
drivers/net/ethernet/marvell/octeontx2/af/rvu_trace.h
drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c

index 5f69380ccc82c332fbb46c9977fd875c9affe2c8..19e0d16b12f6fbfe1732de930d1bc85f684e5ebc 100644 (file)
@@ -12,3 +12,4 @@ EXPORT_TRACEPOINT_SYMBOL(otx2_msg_alloc);
 EXPORT_TRACEPOINT_SYMBOL(otx2_msg_interrupt);
 EXPORT_TRACEPOINT_SYMBOL(otx2_msg_process);
 EXPORT_TRACEPOINT_SYMBOL(otx2_msg_status);
+EXPORT_TRACEPOINT_SYMBOL(otx2_parse_dump);
index db02b4d6ed4bf73a59ff24be061fd445db321dd6..4cd0fc4b0d203865dfa3319c787864571acd7f90 100644 (file)
@@ -133,6 +133,32 @@ TRACE_EVENT(otx2_msg_status,
                      __get_str(str), __entry->num_msgs)
 );
 
+TRACE_EVENT(otx2_parse_dump,
+           TP_PROTO(const struct pci_dev *pdev, char *msg, u64 *word),
+           TP_ARGS(pdev, msg, word),
+           TP_STRUCT__entry(__string(dev, pci_name(pdev))
+                            __string(str, msg)
+                            __field(u64, w0)
+                            __field(u64, w1)
+                            __field(u64, w2)
+                            __field(u64, w3)
+                            __field(u64, w4)
+                            __field(u64, w5)
+           ),
+           TP_fast_assign(__assign_str(dev);
+                          __assign_str(str);
+                          __entry->w0 = *(word + 0);
+                          __entry->w1 = *(word + 1);
+                          __entry->w2 = *(word + 2);
+                          __entry->w3 = *(word + 3);
+                          __entry->w4 = *(word + 4);
+                          __entry->w5 = *(word + 5);
+           ),
+           TP_printk("[%s] nix parse %s W0:%#llx W1:%#llx W2:%#llx W3:%#llx W4:%#llx W5:%#llx\n",
+                     __get_str(dev), __get_str(str), __entry->w0, __entry->w1, __entry->w2,
+                     __entry->w3, __entry->w4, __entry->w5)
+);
+
 #endif /* __RVU_TRACE_H */
 
 #undef TRACE_INCLUDE_PATH
index 9593627b35a3ef1b46e8c4800865124b1223d5fa..99ace381cc78658a5e9253df6413a4d33f0be813 100644 (file)
@@ -335,6 +335,7 @@ static void otx2_rcv_pkt_handler(struct otx2_nic *pfvf,
        struct nix_rx_parse_s *parse = &cqe->parse;
        struct nix_rx_sg_s *sg = &cqe->sg;
        struct sk_buff *skb = NULL;
+       u64 *word = (u64 *)parse;
        void *end, *start;
        u32 metasize = 0;
        u64 *seg_addr;
@@ -342,9 +343,12 @@ static void otx2_rcv_pkt_handler(struct otx2_nic *pfvf,
        int seg;
 
        if (unlikely(parse->errlev || parse->errcode)) {
-               if (otx2_check_rcv_errors(pfvf, cqe, cq->cq_idx))
+               if (otx2_check_rcv_errors(pfvf, cqe, cq->cq_idx)) {
+                       trace_otx2_parse_dump(pfvf->pdev, "Err:", word);
                        return;
+               }
        }
+       trace_otx2_parse_dump(pfvf->pdev, "", word);
 
        if (pfvf->xdp_prog)
                if (otx2_xdp_rcv_pkt_handler(pfvf, pfvf->xdp_prog, cqe, cq,