]> git.ipfire.org Git - thirdparty/sqlalchemy/alembic.git/commitdiff
- add some connection cleanup
authorMike Bayer <mike_mp@zzzcomputing.com>
Sun, 9 Nov 2014 17:33:26 +0000 (12:33 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Sun, 9 Nov 2014 17:33:26 +0000 (12:33 -0500)
tests/test_autogenerate.py
tests/test_batch.py
tests/test_postgresql.py

index 9f6cc002706e3692dca49804968acf0c93491a7c..e9951a7634980466f8556ab32357b0d8bca3ed66 100644 (file)
@@ -58,7 +58,7 @@ class AutogenTest(object):
         clear_staging_env()
 
     def setUp(self):
-        conn = self.bind.connect()
+        self.conn = conn = self.bind.connect()
         ctx_opts = {
             'compare_type': True,
             'compare_server_default': True,
@@ -83,6 +83,9 @@ class AutogenTest(object):
             'context': context
         }
 
+    def tearDown(self):
+        self.conn.close()
+
 
 class AutogenFixtureTest(object):
 
index bbbb0943d50ff522c9019193bb438361e0ebfaa1..0d5edd6b79b0f3c11ce814325dab68ed6824590b 100644 (file)
@@ -355,8 +355,9 @@ class BatchRoundTripTest(TestBase):
 
     def setUp(self):
         self.conn = config.db.connect()
+        self.metadata = MetaData()
         t1 = Table(
-            'foo', MetaData(),
+            'foo', self.metadata,
             Column('id', Integer, primary_key=True),
             Column('data', String(50)),
             Column('x', Integer)
@@ -377,7 +378,7 @@ class BatchRoundTripTest(TestBase):
         self.op = Operations(context)
 
     def tearDown(self):
-        self.conn.execute("drop table foo")
+        self.metadata.drop_all(self.conn)
         self.conn.close()
 
     def _assert_data(self, data):
index f1b2c2d5169750622ddf52574db261262afac790..908eec6db3c66fd896914c8675b96bd35453dd17 100644 (file)
@@ -319,9 +319,10 @@ class PostgresqlDetectSerialTest(TestBase):
     @classmethod
     def setup_class(cls):
         cls.bind = config.db
+        cls.conn = cls.bind.connect()
         staging_env()
         context = MigrationContext.configure(
-            connection=cls.bind.connect(),
+            connection=cls.conn,
             opts={
                 'compare_type': True,
                 'compare_server_default': True
@@ -343,6 +344,7 @@ class PostgresqlDetectSerialTest(TestBase):
 
     @classmethod
     def teardown_class(cls):
+        cls.conn.close()
         clear_staging_env()
 
     @provide_metadata