More annotation of Coverity false positives. (#4568)

This deals with the following CIDs: 1504662, 1469149

diff --git a/src/lib/server/connection.c b/src/lib/server/connection.c
index 5dad7381c3e06fa770427ec8d697088eff4d556c..d5754e212f79c3e48124c32db4b7ea2f933d9608 100644 (file)
--- a/src/lib/server/connection.c
+++ b/src/lib/server/connection.c
@@ -296,6 +296,7 @@ static void connection_deferred_signal_process(fr_connection_t *conn)
                 *      One of the signal handlers freed the connection
                 *      return immediately.
                 */
+               /* coverity[deadcode] */
                if (freed) return;
        }
 

diff --git a/src/lib/unlang/xlat_purify.c b/src/lib/unlang/xlat_purify.c
index 31cace61652cbf34c72ef3948c273db1ccab3e63..7fd44156e95fc7c409c96c87465a7b5c8139343c 100644 (file)
--- a/src/lib/unlang/xlat_purify.c
+++ b/src/lib/unlang/xlat_purify.c
@@ -79,7 +79,7 @@ int xlat_purify_list(xlat_exp_head_t *head, request_t *request)
                default:
                        fr_strerror_printf("Internal error - cannot purify xlat");
                        return -1;
-                       
+
                case XLAT_GROUP:
                        rcode = xlat_purify_list(node->group, request);
                        if (rcode < 0) return rcode;
@@ -102,14 +102,14 @@ int xlat_purify_list(xlat_exp_head_t *head, request_t *request)
                         *      with the children.  But only if the
                         *      child list is not empty.
                         */
-                       
+
                        if (node->alternate[1]->flags.can_purify) {
                                rcode = xlat_purify_list(node->alternate[1], request);
                                if (rcode < 0) return rcode;
                        }
                        xlat_flags_merge(&node->flags, &node->alternate[1]->flags);
                        break;
-                       
+
                case XLAT_FUNC:
                        /*
                         *      If the node is not pure, then maybe there's a callback to purify it, OR maybe
@@ -152,6 +152,7 @@ int xlat_purify_list(xlat_exp_head_t *head, request_t *request)
                         */
                        success = false;
                        (void) unlang_interpret_synchronous(NULL, request);
+                       /* coverity[deadcode] */
                        if (!success) return -1;
 
                        /*