mux: mmio: Fix IS_ERR() vs NULL check in probe()

The devm_kmalloc() function never returns error pointers, it returns
NULL on error.  Fix the error checking.

Fixes: 4863cb2b0f50 ("mux: mmio: Add suspend and resume support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/aSsIP7oKrhKfCUv3@stanley.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/mux/mmio.c b/drivers/mux/mmio.c
index e4ddb1e619237dbb307677a20564eb08f62d11ab..3409af1ffb80f6b58ef67fd15aa8b2b2420bd746 100644 (file)
--- a/drivers/mux/mmio.c
+++ b/drivers/mux/mmio.c
@@ -101,13 +101,13 @@ static int mux_mmio_probe(struct platform_device *pdev)
        mux_mmio = mux_chip_priv(mux_chip);
 
        mux_mmio->fields = devm_kmalloc(dev, num_fields * sizeof(*mux_mmio->fields), GFP_KERNEL);
-       if (IS_ERR(mux_mmio->fields))
-               return PTR_ERR(mux_mmio->fields);
+       if (!mux_mmio->fields)
+               return -ENOMEM;
 
        mux_mmio->hardware_states = devm_kmalloc(dev, num_fields *
                                                 sizeof(*mux_mmio->hardware_states), GFP_KERNEL);
-       if (IS_ERR(mux_mmio->hardware_states))
-               return PTR_ERR(mux_mmio->hardware_states);
+       if (!mux_mmio->hardware_states)
+               return -ENOMEM;
 
        for (i = 0; i < num_fields; i++) {
                struct mux_control *mux = &mux_chip->mux[i];